Deep Learning Software Carpentries Tutorial and JupyterLab Page#966
Deep Learning Software Carpentries Tutorial and JupyterLab Page#966wwarriner merged 36 commits intouabrc:mainfrom
Conversation
There was a problem hiding this comment.
Wow, a lot of great work! Very thorough!
There are some SPAG and style things to work out.
My main concern is the large amount of cross-linked/duplicated content shared between the Jupyter Notebook and JupyterLab pages. Perhaps we could move that content out to a common page "Working with Jupyter Software". Then, at appropriate places in each of the two pages (Notebook, Lab), direct the users to the common page to continue practicing.
Think of it this way... each page (Notebook, Lab) is an introduction to the software and how it works on Cheaha. Once they reader understands the content specific to their chosen software, point them to the shared page.
I envision it like this...
index.md --> jupyter.md --> $common.md
\---> jupyterlab.md ----/
One additional consideration. The Carpentries content is a separate topic and totally separable from the Jupyter content. Can you please migrate it to a separate PR? You can branch off of this branch and push to your fork and start a new PR that way.
|
I need to clarify about the second person pronoun "you". If you want to use them that is generally OK, but be consistent. Either stick to "we/you" or avoid it. Mostly it is avoided in your work, hence my suggestions to remove. |
There was a problem hiding this comment.
Great, very close! I went ahead and made some cleanup type changes, and renamed the ood_jupyter.md file.
Not all of the comments need fixing, some are FYI.
The major thing we need changed is the long bullets in "Why use *?" sections. If you have need for list-within-list, first consider if that's really necessary, then break it up into itemized lists.
wwarriner
left a comment
There was a problem hiding this comment.
Good work! Made some reorg tweaks, and this is ready to merge.
|
Please make an issue to enhance this page using templates/macros (when available). |
Pull Request
Overview
Added links for Software Carpentries Deep Learning tutorial to our docs. The PR also includes the JupyterLab page.
Proposed Changes
Related Issues
Fixes #924