Add FeatureKey #171
Merged
Add FeatureKey #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This generalizes and polishes up a pattern that I've seen in our internal adoption of LaunchDarkly - define a key and it's default once, to make any updates easy to manage. It follows that the type of each key will be mostly static as well, so a way to define this once in the code is provided.
This provides interop between LDValue and circe.Json, as well as helper methods to retrieve variations that are either JSON or encoded as JSON.
This was referenced Apr 1, 2025
Contributor
Author
|
@bplommer could I get a review on this PR? |
zarthross
reviewed
May 29, 2025
circe/src/main/scala/org.typelevel/catapult/circe/LDValueCodec.scala
Outdated
Show resolved
Hide resolved
circe/src/main/scala/org.typelevel/catapult/circe/LDValueCodec.scala
Outdated
Show resolved
Hide resolved
circe/src/main/scala/org/typelevel/catapult/circe/syntax/client.scala
Outdated
Show resolved
Hide resolved
circe/src/main/scala/org/typelevel/catapult/circe/syntax/client.scala
Outdated
Show resolved
Hide resolved
circe/src/main/scala/org/typelevel/catapult/circe/syntax/client.scala
Outdated
Show resolved
Hide resolved
circe/src/main/scala/org.typelevel/catapult/circe/CirceFeatureKey.scala
Outdated
Show resolved
Hide resolved
circe/src/main/scala/org.typelevel/catapult/circe/CirceFeatureKey.scala
Outdated
Show resolved
Hide resolved
circe/src/main/scala/org/typelevel/catapult/circe/syntax/mtlClient.scala
Outdated
Show resolved
Hide resolved
circe/src/main/scala/org/typelevel/catapult/circe/syntax/mtlClient.scala
Outdated
Show resolved
Hide resolved
….scala Co-authored-by: Darren Gibson <[email protected]>
….scala Co-authored-by: Darren Gibson <[email protected]>
…t.scala Co-authored-by: Darren Gibson <[email protected]>
…t.scala Co-authored-by: Darren Gibson <[email protected]>
…Key.scala Co-authored-by: Darren Gibson <[email protected]>
…Key.scala Co-authored-by: Darren Gibson <[email protected]>
…ient.scala Co-authored-by: Darren Gibson <[email protected]>
…ient.scala Co-authored-by: Darren Gibson <[email protected]>
Needed to support circe functionality
Collaborator
|
Hi! Apologies for dropping the ball on this. I'm happy to try and take a look soon - however I've been dealing with some health issues and burnout so I don't want to over-promise. I'm happy for you to go ahead with merging / releasing if you prefer so that I won't be a blocker. |
Contributor
Author
That's fair, hope you get the rest you need 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes and polishes up a pattern that I've seen in our internal adoption of LaunchDarkly - define a key and it's default once, to make any updates easy to manage.
It follows that the type of each key will be mostly static as well, so a way to define this once in the code is provided.