Fix error handling when error is not an array#131
Open
Nargonath wants to merge 2 commits intotwitter-together:mainfrom
Open
Fix error handling when error is not an array#131Nargonath wants to merge 2 commits intotwitter-together:mainfrom
Nargonath wants to merge 2 commits intotwitter-together:mainfrom
Conversation
Contributor
Author
|
Also now the CI/CD properly fails when throw the error for the missing account_id which was not the case before. |
Nargonath
force-pushed
the
fix-handle-error-when-not-array
branch
from
fe4de17 to
4372851
Compare
Contributor
Author
|
I added the missing test to bring coverage to 100%. There is an error still but I don't understand it. I don't know how to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is linked to #124. It fixes the second error which was basically noise. FWIU Twitter returns errors as an array however when you throw an error because the
TWITTER_ACCOUNT_IDis not set,errors[0]returnsundefined. Then at this line you go through the array of errors and try to accesserror.messagebut sinceerroris undefined you get the second error message I posted in the issue.