Skip to content

Conversation

@civerachb-cpr
Copy link
Contributor

Description

On Ubuntu Server 24.04 on Raspberry Pi editing the hostname in /etc/hostname alone is not sufficient to keep the new hostname to persist across reboots. /boot/firmware/user-data also needs to be updated with the hostname

Fixes #16.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested internally on cpr-raphael by using the turtlebot4_setup tool with this change.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

…ame to ensure it persists properly across reboots
@civerachb-cpr civerachb-cpr added the bug Something isn't working label Feb 20, 2025
Copy link
Contributor

@hilary-luo hilary-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I was reviewing this I also noticed that in Jazzy, the hostname was added to /etc/turtlebot4/system but is never read or written to that location. Can we also remove that since it can be misleading.

@civerachb-cpr civerachb-cpr merged commit 9bcccae into jazzy Mar 4, 2025
2 checks passed
@civerachb-cpr civerachb-cpr deleted the fix-hostname-persistence branch March 4, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

turtlebot-setup does not change hostname

3 participants