Skip to content

Conversation

@wpjunior
Copy link
Member

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for multiple validate_claims constraints, allowing the validation function to accept an array of constraint sets and return success if any one constraint set passes validation.

  • Added array support to the validate_claims function with OR logic between constraints
  • Implemented is_array helper function to detect array-like tables
  • Added comprehensive test coverage for the new array functionality

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
lib/resty/libjwt/utils.lua Added array handling logic and is_array helper function to support multiple constraint validation
test/validate_claims_test.lua Added test case covering array constraint validation scenarios including success and failure cases

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wpjunior wpjunior requested a review from Copilot October 16, 2025 14:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@wpjunior wpjunior requested a review from Copilot October 16, 2025 17:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@ravilock ravilock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wpjunior wpjunior merged commit 215406f into main Oct 16, 2025
3 checks passed
@wpjunior wpjunior deleted the feature/multiple-validate-claims-constraints branch October 16, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants