You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One thing I was thinking, and please correct me if I'm wrong on this: if words is not specified, and you do have the W3W app installed, it will show this as an option, but will just show your current location in the app.
That seems like potentially confusing behaviour - should we only show W3W as an option if, either:
You've explicitly asked for app: "w32" in the showLocation() call
I agree, I think it would be best if the option to use w3w is shown only when the words property is set. Also, the lat/lng isn't really necessary for the w3w provider, however it is a required field in the validation for all other apps, so I'm not sure if this is worth excluding from the validation if the words property is included. Unfortunately the w3w linking doesn't support lat/lng as parameters, which would be a nice fallback.
I'll try and see where the best place to put this logic might be for excluding from the list of available apps.
Thanks for your feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Thomas,
I'd like to add support for what3words as a mapping provider, however I've not worked on a typescript package before and unsure with the testing part.
Would you be able to check if this is would be suitable for your package please? This is the link for the w3w site:
https://developer.what3words.com/tutorial/mobile-linking-to-the-what3words-app
Luke