feature: make alloy version settable #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This pull request adds the ability to specify a custom Alloy version for deployment and updates, rather than always defaulting to the latest version. Users can now set a specific version (e.g., "v1.12.0") via the --alloy.version flag in both deploy and update commands.
Key Changes:
- Refactored version fetching logic to support both "latest" and specific version strings
- Added
--alloy.versionflag to deploy and update commands with "latest" as default - Updated download URL construction to handle versioned releases
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/agent/update.go | Extracted latest tag fetching into separate function and added version parameter support to update flow |
| internal/agent/deploy.go | Modified download URL construction to handle both "latest" and specific version strings |
| internal/agent/agent.go | Added version parameter to Deploy and Update public methods |
| cmd/agent/update.go | Added --alloy.version flag and passed it to Update method |
| cmd/agent/deploy.go | Added --alloy.version flag and passed it to Deploy method |
| internal/agent/agent_test.go | Updated test calls to include "latest" version parameter |
tschaefer
force-pushed
the
feature/make-alloy-version-settable
branch
from
3c81f4c to
48e1008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.