Add full support for generics#11
Merged
sosthene-nitrokey merged 3 commits intotrussed-dev:mainfrom May 26, 2025
Merged
Conversation
sosthene-nitrokey
force-pushed
the
full-generics
branch
from
a89f094 to
8d14c56
Compare
robin-nitrokey
approved these changes
Feb 17, 2025
Member
robin-nitrokey
left a comment
robin-nitrokey
left a comment
There was a problem hiding this comment.
LGTM (except for the clippy error).
Contributor
Author
|
The clippy error is fixed as part of #16 which is built on top of this. |
This patch adds tests based on `serde_test`. These tests helped showcase the bug that leads to trussed-dev#2
sosthene-nitrokey
force-pushed
the
full-generics
branch
from
8d14c56 to
ac9788d
Compare
robin-nitrokey
approved these changes
Feb 17, 2025
Member
|
Can we merge this before #14 please? That makes it easier to review the changes in the other PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
constgenerics and generic types, in addition to the current support for lifetime generics.In testing the PR with
serde-test, this also showed the underlying bug for #2 (theToken::Somefailed to de-serialize), so this PR includes a fix.Fix #9 and #2