Add a unstable-disable-block-count-check feature that removes the block count check#26
Merged
sosthene-nitrokey merged 1 commit intomainfrom Apr 16, 2025
Merged
Conversation
sosthene-nitrokey
force-pushed
the
remove-mount-block-count
branch
from
28c3564 to
268e33e
Compare
daringer
approved these changes
Apr 14, 2025
Comment on lines
24
to
28
| + if (lfs->cfg->block_count) { | ||
| + lfs->block_count = lfs->cfg->block_count; | ||
| + } |
Member
There was a problem hiding this comment.
AFAIS this breaks the case where lfs->cfg->block_count is zero. We should either handle it or return LFS_ERR_INVAL in that case.
Suggested change
| + if (lfs->cfg->block_count) { | |
| + lfs->block_count = lfs->cfg->block_count; | |
| + } | |
| + if (lfs->cfg->block_count) { | |
| + lfs->block_count = lfs->cfg->block_count; | |
| + } else { | |
| + lfs->block_count = superblock.block_count; | |
| + } |
sosthene-nitrokey
force-pushed
the
remove-mount-block-count
branch
from
268e33e to
7800070
Compare
remove-mount-check.patch
Outdated
| + if (lfs->cfg->block_count) { | ||
| + lfs->block_count = lfs->cfg->block_count; | ||
| + } else { | ||
| + |
…lock count check Upstream PR: littlefs-project/littlefs#584 introduced a check that the block count matches the superblock. However that can cause some issues for filesystem that were formatted with a wrong block count and later corrected.
sosthene-nitrokey
force-pushed
the
remove-mount-block-count
branch
from
7800070 to
65fb5cd
Compare
robin-nitrokey
approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream PR: littlefs-project/littlefs#584 introduced a check that the block count matches the superblock.
However that can cause some issues for filesystem that were formatted with a wrong block count and later corrected.