Fix code generation with multiversion feature and release v0.3.1#23
Merged
robin-nitrokey merged 1 commit intomainfrom Feb 26, 2025
Merged
Fix code generation with multiversion feature and release v0.3.1#23robin-nitrokey merged 1 commit intomainfrom
robin-nitrokey merged 1 commit intomainfrom
Conversation
During rebasing of #19, the line that enables the LFS_MULTIVERSION feature flag not only for the compilation but also for the code generation somehow got lost. This patch updates the build script and prepares the bugfix release v0.3.1.
sosthene-nitrokey
approved these changes
Feb 26, 2025
Contributor
|
Once merged and released we should also yank version 0.3.0. Since this is technically a breaking change. |
Member
Author
|
I don’t see the need to yank v0.3.0. In my opinion, fixing broken code can never be a breaking change. If the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During rebasing of #19, the line that enables the LFS_MULTIVERSION feature flag not only for the compilation but also for the code generation somehow got lost. This patch updates the build script and prepares the bugfix release v0.3.1.