Skip to content

Conversation

@McPatate
Copy link

closes #4499

Description:

Adds the OpenRouter detector as discussed in #4499.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

Note: I ran make lint and I'm seeing quite the list of warnings, although none related to the changes I made afaict. Is this safe to ignore?

@McPatate McPatate requested review from a team as code owners October 15, 2025 13:01
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrt to the fmt changes, I can revert them, not sure which fmt I have enabled atm!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not update this file. You need to add the detector enum to the detectors.proto and then run make protos for the new changes to reflect in this file.

More details here: https://github.com/trufflesecurity/trufflehog/blob/main/hack/docs/Adding_Detectors_external.md

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought I did something wrong, mb will fix

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@McPatate McPatate force-pushed the feat/add_openrouter_detector branch from f436f10 to 8cee242 Compare October 15, 2025 14:00
@McPatate McPatate requested a review from a team as a code owner October 15, 2025 14:00
@McPatate McPatate force-pushed the feat/add_openrouter_detector branch from c192f0c to 8cee242 Compare October 16, 2025 13:03
@McPatate
Copy link
Author

Hey @shahzadhaider1, lmk if there's anything needed from me to move this PR forward!

@shahzadhaider1
Copy link
Contributor

Hey @shahzadhaider1, lmk if there's anything needed from me to move this PR forward!

Hey @McPatate, thank you for the contribution. It looks good, but we’re currently pausing the addition of new detectors. We’ll get this merged once we’ve refined our process for maintaining them.

@McPatate
Copy link
Author

Ok thanks for letting me know! Do you have an idea of the timeline wrt to:

We’ll get this merged once we’ve refined our process for maintaining them.

?

@camgunz
Copy link
Contributor

camgunz commented Nov 6, 2025

Thanks for your patience @McPatate -- we're kicking around ideas for getting this merged in a stable fashion. I should have more for you soon; hopefully today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add openrouter detector

3 participants