-
Notifications
You must be signed in to change notification settings - Fork 0
chore(deps): minor update quay.io/strimzi/kafka docker tag to v0.49.0-kafka-4.1.0 #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cheetahbot
wants to merge
2
commits into
main
Choose a base branch
from
renovate/quay.io/strimzi/kafka-minor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ BASH | shellcheck | 5 | 0 | 0 | 0.14s | |
| shfmt | 5 | 1 | 0 | 0.01s | ||
| ✅ COPYPASTE | jscpd | yes | no | no | 1.6s | |
| ✅ DOCKERFILE | hadolint | 2 | 0 | 0 | 0.07s | |
| ✅ JSON | jsonlint | 4 | 0 | 0 | 0.2s | |
| ✅ JSON | prettier | 4 | 0 | 0 | 1.1s | |
| ✅ JSON | v8r | 4 | 0 | 0 | 2.58s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.02s | |
| ✅ REPOSITORY | grype | yes | no | no | 31.38s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.85s | |
| ✅ REPOSITORY | trivy | yes | no | no | 10.81s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.12s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 5.71s | |
| prettier | 19 | 1 | 4 | 0.93s | ||
| ✅ YAML | v8r | 19 | 0 | 0 | 6.36s | |
| yamllint | 19 | 8 | 0 | 0.9s |
Detailed Issues
⚠️ YAML / prettier - 1 error
Checking formatting...
[warn] .github/workflows/e2e.yaml
[warn] config/redpanda-admin.yaml
[warn] config/redpanda-cluster.yaml
[warn] Code style issues found in 3 files. Run Prettier with --write to fix.
⚠️ BASH / shfmt - 1 error
diff config/keycloak/keycloak_custom_role_creation.sh.orig config/keycloak/keycloak_custom_role_creation.sh
--- config/keycloak/keycloak_custom_role_creation.sh.orig
+++ config/keycloak/keycloak_custom_role_creation.sh
@@ -13,7 +13,7 @@
# Build the roles_definition_substitution string for $(env:DEMO_ROLES_DEFINITION)
roles_definition_substitution=""
for role in "${roles_array[@]}"; do
- roles_definition_substitution+="{\"name\":\"$role\"},"
+ roles_definition_substitution+="{\"name\":\"$role\"},"
done
# Remove the trailing comma
roles_definition_substitution="${roles_definition_substitution%,}"
@@ -21,7 +21,7 @@
# Build the client_roles_substitution string for $(env:DEMO_CLIENT_ROLES) using a loop
client_roles_substitution="["
for role in "${roles_array[@]}"; do
- client_roles_substitution+="\"$role\","
+ client_roles_substitution+="\"$role\","
done
# Remove the trailing comma
client_roles_substitution="${client_roles_substitution%,}"
@@ -29,7 +29,7 @@
# Perform substitutions and save to output file
sed -e "s/\$(env:DEMO_ROLES_DEFINITION)/$roles_definition_substitution/g" \
- -e "s/\$(env:DEMO_CLIENT_NAME)/$DEMO_CLIENT_NAME/g" \
- -e "s/\$(env:DEMO_CLIENT_SECRET)/$DEMO_CLIENT_SECRET/g" \
- -e "s/\$(env:DEMO_CLIENT_ROLES)/$client_roles_substitution/g" \
- "$input_file" > "$output_file"
\ No newline at end of file
+ -e "s/\$(env:DEMO_CLIENT_NAME)/$DEMO_CLIENT_NAME/g" \
+ -e "s/\$(env:DEMO_CLIENT_SECRET)/$DEMO_CLIENT_SECRET/g" \
+ -e "s/\$(env:DEMO_CLIENT_ROLES)/$client_roles_substitution/g" \
+ "$input_file" >"$output_file"
⚠️ YAML / yamllint - 8 errors
.github/workflows/e2e.yaml
4:1 warning truthy value should be one of [false, true] (truthy)
79:1 error trailing spaces (trailing-spaces)
.github/workflows/megalinter.yaml
4:1 warning truthy value should be one of [false, true] (truthy)
config/opensearch_dashboards/opensearch_dashboards.yml
32:14 warning truthy value should be one of [false, true] (truthy)
config/redpanda-admin.yaml
14:8 error trailing spaces (trailing-spaces)
17:5 warning comment not indented like content (comments-indentation)
config/redpanda-cluster.yaml
20:8 error trailing spaces (trailing-spaces)
23:5 warning comment not indented like content (comments-indentation)
See detailed reports in MegaLinter artifacts
Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining FLAVOR_SUGGESTIONS: false)
- Documentation: Custom Flavors
- Command:
npx mega-linter-runner@9.2.0 --custom-flavor-setup --custom-flavor-linters BASH_SHELLCHECK,BASH_SHFMT,COPYPASTE_JSCPD,DOCKERFILE_HADOLINT,JSON_JSONLINT,JSON_V8R,JSON_PRETTIER,REPOSITORY_GIT_DIFF,REPOSITORY_GRYPE,REPOSITORY_SYFT,REPOSITORY_TRIVY,REPOSITORY_TRIVY_SBOM,REPOSITORY_TRUFFLEHOG,YAML_PRETTIER,YAML_YAMLLINT,YAML_V8R
9cf346a to
40ef124
Compare
f304d6e to
1976e3e
Compare
deed947 to
dde1281
Compare
dde1281 to
0c3bc52
Compare
Contributor
|
Zookeeper references must be removed before this PR can be merged |
0c3bc52 to
30c1f7d
Compare
166e202 to
d5ff852
Compare
d5ff852 to
5f31c18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This PR contains the following updates:
0.48.0-kafka-4.1.0->0.49.0-kafka-4.1.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - "after 12pm and before 4pm every weekday" in timezone Europe/Copenhagen.
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Renovate Bot.