Skip to content

Make glob an optional dependency#1373

Draft
squell wants to merge 4 commits intomainfrom
loosen-glob
Draft

Make glob an optional dependency#1373
squell wants to merge 4 commits intomainfrom
loosen-glob

Conversation

@squell
Copy link
Member

@squell squell commented Dec 3, 2025

Should we also make it the non-default?

CC #834

@squell squell added dependencies Pull requests that update a dependency file freeze Temporarily blocked from merging pending a release and removed freeze Temporarily blocked from merging pending a release labels Dec 15, 2025
@squell squell mentioned this pull request Dec 17, 2025
@squell squell marked this pull request as ready for review December 19, 2025 11:13
@squell
Copy link
Member Author

squell commented Dec 19, 2025

After discussion with Ruben: let's leave Rust-glob the default for now, but I propose we give packagers an option.

I'm open to suggestion for a different feature name, we could also call it fnmatch (that then enables using libc's fnmatch), any preferences?

@squell squell linked an issue Dec 19, 2025 that may be closed by this pull request
@squell
Copy link
Member Author

squell commented Jan 14, 2026

Note: I've done some differential fuzzing between glibc, musl and glob and I have some reasons to prefer glob for now.

@squell squell added freeze Temporarily blocked from merging pending a release and removed freeze Temporarily blocked from merging pending a release labels Feb 9, 2026
@squell squell marked this pull request as draft February 9, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible glob incompatibility with original sudo

2 participants