Skip to content

Conversation

@ImperialSquid
Copy link
Contributor

@ImperialSquid ImperialSquid commented Mar 26, 2025

After #74 and #76 were merged I decided to remake this one just to cut down on the list of commits and mess (I think the idea of doing several PRs that build on each other is interesting but maybe too complex for me lol). Anyway...


This implements filtering notes by notebook IDs 🎉

Now the list to include can be a comma separated list of names, IDs, or both, eg <notebook name>,<notebook ID>,<notebook name>

The code will:

  • take each item in the list and first try to find a matching notebook using it as an ID
  • if it finds a match, that notebook is added to the filter list
  • if it fails to find a match (eg the text doesn't fit Joplin's ID format, or it's the right format but we find nothing), the text is then treated as a title to match on
    • this preserves the previous functionality so all updating users won't need to update their settings

Let me know if any of the above needs clarifying or if there's anything more I can do to help!

@ImperialSquid
Copy link
Contributor Author

@treymo this one is good to go, will remake the other two soon 👌

@ImperialSquid ImperialSquid changed the title PR: Better Filtering (Notebook IDs PR: Better Filtering (Notebook IDs) Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant