Option to capitalise "p" in p-values #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
==========================================
+ Coverage 91.37% 91.44% +0.06%
==========================================
Files 31 34 +3
Lines 2493 2477 -16
==========================================
- Hits 2278 2265 -13
+ Misses 215 212 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
trevismd
approved these changes
Mar 22, 2025
Owner
trevismd
left a comment
trevismd
left a comment
There was a problem hiding this comment.
Nice feature, thank you for the contribution, @Pentabyteman !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some journals (i.e. Nature portfolio) prefer capital "P" for p-values when preparing figures (i.e. "P = 0.027", not "p = 0.027").
This pull request adds p_capitalized as a parameter to PValueFormat (with default set to False to keep current behaviour) to allow easy configuration of the capitalisation of the letter, as well as two tests.