-
Notifications
You must be signed in to change notification settings - Fork 17
[TRNT-4139] Allow serving Trento from a subpath #3948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
antgamdia
wants to merge
14
commits into
main
Choose a base branch
from
TRNT-4139-support-subpaths
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
4ff1497 to
c86d3d7
Compare
c86d3d7 to
cb63895
Compare
Signed-off-by: Antonio Gamez Diaz <antonio.gamez@suse.com>
cb63895 to
c71aece
Compare
Member
|
Hey @antgamdia, porting here the summary of our private discussion. While I believe trento would benefit from being able to be exposed in a subpath, I am also not feeling confident it pursuing this path at this very moment. We'd need to take extra attention about at least the following:
If you ask me, I would defer any commitment on this at this stage 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the handling of routes and paths when Trento is deployed and served from a subpath, such as
foo.example.com/trento.The rationale is: the reverse proxy adds the usual
x-forwarded-prefixto set the subpath where it is being served. Later, TrentoWeb uses this header to calculate thescript_namevariable that Phoenix uses. The heex templates are updated to honor this variable as well. Finally, some minor tweaks are required on the frontend side, namely: 1) update the base URL in HTTP clients; 2) update some manual redirects (logging in/out) and 3) use relative URLs in some places.Fixes TRNT-4139
How was this tested?
Unit tests, e2e tests, IRL tests.
Additional information