fix(stats): Exclude transfer transactions from aggregation statistics#67
Merged
fix(stats): Exclude transfer transactions from aggregation statistics#67
Conversation
Code Review SummaryThe PR fixes a bug where internal transfers were inflating income and expense statistics. It updates several client-side aggregation functions and enhances the API data transformation logic to include more detailed activity metrics. 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
Deploying webui with
|
| Latest commit: |
f1480ee
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1e245b3b.webui-9fh.pages.dev |
| Branch Preview URL: | https://fix-exclude-transfers-from-s.webui-9fh.pages.dev |
Deploying trakli-dev with
|
| Latest commit: |
f1480ee
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://934e545a.trakli-dev.pages.dev |
| Branch Preview URL: | https://fix-exclude-transfers-from-s.trakli-dev.pages.dev |
nfebe
force-pushed
the
fix/exclude-transfers-from-stats
branch
from
2d02bf3 to
c0f3857
Compare
nfebe
force-pushed
the
fix/exclude-transfers-from-stats
branch
from
c0f3857 to
84d82c4
Compare
nfebe
force-pushed
the
fix/exclude-transfers-from-stats
branch
from
84d82c4 to
f145282
Compare
Transfers between accounts were incorrectly counted as income/expense in client-side calculations, causing wrong top sources.
nfebe
force-pushed
the
fix/exclude-transfers-from-stats
branch
from
f145282 to
f1480ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transfers between accounts were incorrectly counted as income/expense in client-side calculations, causing wrong top sources.