2.0 rc #257
Merged
2.0 rc #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- tests pass - config object is now copied during merge - TODO migrate motd and validation schemas
- after and onceAny now support both Promise and handler callbacks - fixed parameter passing in after method - added unit tests
jaumard
reviewed
Nov 15, 2016
index.js
Outdated
| if (!events) | ||
| return | ||
| if (!Array.isArray(events)) | ||
| onceAny (events, handler = NOOP) { |
Contributor
There was a problem hiding this comment.
This will not work for node < 6 :( default value are comping with node 6
Member
Author
There was a problem hiding this comment.
yep, tests are failing, I'll fix.
jaumard
reviewed
Nov 16, 2016
index.js
Outdated
| if (!app.pkg) { | ||
| throw new lib.Errors.PackageNotDefinedError() | ||
| } | ||
| if (!app.api && !(app && app.api)) { |
Contributor
There was a problem hiding this comment.
One seems useless here right ?
- config.env is set to the (string) value of NODE_ENV
Member
|
Can we add #236 to this PR? |
Closed
Member
|
We should also look at #216 for the RC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
2.0 release candidate branch
Issues