Remove Future Sync bound from ServiceBuilder::boxed_clone_sync()#851
Merged
jplatte merged 3 commits intotower-rs:masterfrom Feb 12, 2026
Merged
Remove Future Sync bound from ServiceBuilder::boxed_clone_sync()#851jplatte merged 3 commits intotower-rs:masterfrom
Sync bound from ServiceBuilder::boxed_clone_sync()#851jplatte merged 3 commits intotower-rs:masterfrom
Conversation
The function Future bounds are slightly too restrictive. Namely: ``` <L::Service as Service<R>>::Future: Send + Sync + 'static, ``` The `BoxCloneSyncService` and `BoxCloneSyncServiceLayer` require: ``` S::Future: Send + 'static, <L::Service as Service<T>>::Future: Send + 'static, ``` Removing the `Sync` bound from the helper function: - Makes the helper function more useful (where futures are not `Sync`) - Is backwards compatible (loosening trait bound)
jplatte
approved these changes
Feb 5, 2026
Member
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
Mind adding a changelog entry? You can put a new Unreleased heading / section before the latest release.
jplatte
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function Future bounds are slightly too restrictive. Namely:
The
BoxCloneSyncServiceandBoxCloneSyncServiceLayerrequire:Removing the
Syncbound from the helper function:Sync)