-
-
Notifications
You must be signed in to change notification settings - Fork 446
refactor: imports from typing instead of typing-extensions #2051
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
waketzheng
merged 14 commits into
tortoise:develop
from
waketzheng:no-typing-extensions
Jan 14, 2026
Merged
refactor: imports from typing instead of typing-extensions #2051
waketzheng
merged 14 commits into
tortoise:develop
from
waketzheng:no-typing-extensions
Jan 14, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 20910072933Details
💛 - Coveralls |
henadzit
previously approved these changes
Jan 11, 2026
henadzit
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2049
Motivation and Context
If TYPE_CHECKING, import 'Self' from typing when python>=3.11, otherwise from typing-extensions
How Has This Been Tested?
make ci
Checklist: