Skip to content

Conversation

@waketzheng
Copy link
Contributor

@waketzheng waketzheng commented Dec 26, 2025

Description

Fixes #2049

Motivation and Context

If TYPE_CHECKING, import 'Self' from typing when python>=3.11, otherwise from typing-extensions

How Has This Been Tested?

make ci

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added the changelog accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 26, 2025

Merging this PR will not alter performance

✅ 16 untouched benchmarks


Comparing waketzheng:no-typing-extensions (d610e38) with develop (c89bbe0)

Open in CodSpeed

@coveralls
Copy link

coveralls commented Dec 28, 2025

Pull Request Test Coverage Report for Build 20910072933

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 90.676%

Totals Coverage Status
Change from base Build 20909968220: -0.001%
Covered Lines: 6647
Relevant Lines: 7215

💛 - Coveralls

henadzit
henadzit previously approved these changes Jan 11, 2026
@waketzheng waketzheng requested a review from henadzit January 12, 2026 13:26
@waketzheng waketzheng merged commit 4c1faa0 into tortoise:develop Jan 14, 2026
11 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Self' in python standard library typing.py, but tortoise/model.py required it in 'typing_extensions'

3 participants