Skip to content

Fix xlsx export tmpfile leaks#82

Merged
supertassu merged 3 commits intomainfrom
taavi/excel
May 26, 2025
Merged

Fix xlsx export tmpfile leaks#82
supertassu merged 3 commits intomainfrom
taavi/excel

Conversation

@supertassu
Copy link
Member

  • build: Upgrade xlsxwriter
  • output: Run Excel export in a specific temporary directory

Bug: T395237

Bug: T395237
Change-Id: Ib3a1640ffeef6db53901b07c6ab3bf642ab53fd4
@supertassu supertassu requested a review from dhinus May 26, 2025 10:00
Currently Quarry is leaking temporary files that seem to be caused by
this. My testing indicates that the last commit which upgraded
xlsxwriter fixed that, but just to be sure, run the export in a
temporary directory that will be cleaned up afterwards instead of doing
it in /tmp which has a possibility of accumulating leaked files.

Bug: T395237
Change-Id: I7dc3ad3a7b638634e156f9350ea8b278ad64870b
Copy link
Member

@dhinus dhinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@supertassu supertassu merged commit 1e906fa into main May 26, 2025
3 checks passed
@supertassu supertassu deleted the taavi/excel branch June 13, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants