Skip to content

Fix Memory Leak #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Selyatin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix Memory Leak #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions Sources/MarkdownWebView/MarkdownWebView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,30 @@ import WebKit
#elseif os(iOS)
public func makeUIView(context: Context) -> CustomWebView { context.coordinator.platformView }
#endif

#if os(macOS)
public static func dismantleNSView(_ nsView: CustomWebView, coordinator: Coordinator) {
let platformView = coordinator.platformView

platformView.configuration.userContentController.removeScriptMessageHandler(
forName: "sizeChangeHandler")
platformView.configuration.userContentController.removeScriptMessageHandler(
forName: "renderedContentHandler")
platformView.configuration.userContentController.removeScriptMessageHandler(
forName: "copyToPasteboard")
}
#elseif os(iOS)
public static func dismantleUIView(_ uiView: CustomWebView, coordinator: Coordinator) {
let platformView = coordinator.platformView

platformView.configuration.userContentController.removeScriptMessageHandler(
forName: "sizeChangeHandler")
platformView.configuration.userContentController.removeScriptMessageHandler(
forName: "renderedContentHandler")
platformView.configuration.userContentController.removeScriptMessageHandler(
forName: "copyToPasteboard")
}
#endif

func updatePlatformView(_ platformView: CustomWebView, context _: Context) {
guard !platformView.isLoading else { return } /// This function might be called when the page is still loading, at which time `window.proxy` is not available yet.
Expand Down