Fix additionally form_key element #219
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace <input name="form_key"> with <meta name="tumblr-form-key" id="tumblr_form_key" content="xxxx"> @ailispaw refs tombfix#216
ailispaw
reviewed
Jul 24, 2017
| return this.getDashboard().addCallback(doc => { | ||
| let info = {}; | ||
| let element = doc.querySelector('input[name="form_key"]'); | ||
| let element = doc.querySelector('meta[name="tumblr-form-key"]') || doc.querySelector('meta[id="tumblr-form-key"]'); |
There was a problem hiding this comment.
説明が下手ですみません。
本来なら、input[name="form_key"] はそのままで、
meta[id="tumblr_form_key"] か meta[name="tumblr-form-key"] のどちらかを追加するだけで大丈夫なはずです。
#218 (comment)
で微妙と書いたのは、id の方は _ アンダースコアで、name は - ハイフンになっているところです。
ただ、input[name="form_key"] を残しても、下のコードが element.content だけなので、meta のみを前提にしているので、あまり意味が無いかもしれませんが。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @gkojax @ailispaw
if fix additionally to #218 , revoke this pull request.
fixes #216