Add SVGDoc and SVGSerialize functions for SVG document creation and serialization. #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serialization. [Feature] Signed-off-by: Markus Alexander Kuppe <[email protected]>
lemmy
force-pushed
the
mku-SVGSerialize
branch
from
ab18c6a to
e216cc1
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality for creating complete SVG documents and serializing them to files. It introduces two new operators: SVGDoc for creating SVG documents with proper namespace declarations and viewBox configuration, and SVGSerialize for writing SVG content to disk.
Key Changes:
- Added
SVGDocoperator to create properly structured SVG documents with viewBox and namespace attributes - Added
SVGSerializeoperator to write SVG documents to files with customizable naming - Comprehensive test coverage for both new operators including edge cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| modules/SVG.tla | Implements SVGDoc and SVGSerialize operators with detailed documentation |
| tests/SVGTests.tla | Adds test cases validating SVGDoc structure, string conversion, and SVGSerialize file operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature]