-
Notifications
You must be signed in to change notification settings - Fork 13
Mintlify Docs Edits #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Mintlify Docs Edits #523
Conversation
snippets/shared/send-tx-concepts.mdx
Outdated
|
|
||
| | **Status** | **API Request Response** | **Description** | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need the API Request Response column on the Statuses table.
snippets/shared/send-tx-concepts.mdx
Outdated
|
|
||
| ### **Transaction Errors** | ||
|
|
||
| | **Status** | **API Request Response** | **Description** | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, I don't think we need the API Request Response column on this table.
snippets/shared/send-tx-concepts.mdx
Outdated
| | UNKNOWN | ErrorTypeUnknown | The transaction failed for an unspecified or unclassified reason | | ||
| | NATIVE | ErrorTypeNative | The transaction failed due to a blockchain-native error, such as a revert, invalid opcode, insufficient balance, or other execution-level failure returned by the network. | | ||
| | CUSTOM | ErrorTypeCustom | The transaction failed due to a Turnkey-defined or application-specific error, such as invalid inputs, sponsorship policy violations, nonce conflicts, or internal validation failures. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
X-Posting here
The error section isn't quite right. The UNKNOWN , NATIVE CUSTOM error types describe how an EVM smart contract reverted during on-chain execution ( or pre-flight simulation). They are never used to describe Turnkey-defined or application-specific errors
Native — Built-in Solidity reverts: require(), assert(), plain revert()
Custom — Contract-defined errors using Solidity's error keyword
Unknown — Revert data we couldn't decode (missing ABI, unverified contract)
Turnkey application Errors such as signing, or policy rejection will be described in Error.Message and aren't classified by any specific error type
|
Capturing this comment from @t-vila so I dont forget: in the tx automation example https://turnkey-0e7c1f5b-sponsored-tx-docs-121.mintlify.app/signing-automation/code-examples/sending-sponsored-transactions@turnkey/core would not work on node.js servers, for backend people need to use @turnkey/sdk-serverI think we should be a little bit more explicit and have a 3rd point in SDK Overview3. Using server-side @turnkey/sdk-serverand I guess also mentioning how the sdk-server client is defined in Step 1import { Turnkey } from "@turnkey/sdk-server"; const client = new Turnkey({ |
Co-authored-by: DeRauk Gibble <[email protected]>
|
|
||
| - Base - eip155:8453 | ||
| - Polygon - eip155:137 | ||
| - Ethereum - eip155:1 (Coming soon) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're here, could you remove the (Coming soon) piece for mainnet?
No description provided.