Clean up some temporary files #1227
Open
+38
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
Jan 19, 2026
|
|
||
| test -n "$DEBUG" && sort -nr "$DEBUG" | ||
|
|
||
| rm -f "$DEBUG" "$MERGED_LOG" |
Collaborator
There was a problem hiding this comment.
If the -d flag is not provided, $DEBUG is empty. rm -f "" exits with code 1. Since this is the final command, the script returns a failure status.
| fi; \ | ||
| if [ "$$should_install" = 'yes' ]; then \ | ||
| echo "... installing $(COMMAND)"; \ | ||
| head -1 bin/$(COMMAND) > $(TEMPFILE); \ |
Collaborator
There was a problem hiding this comment.
What about building the script content in a subshell and redirecting it directly to the destination? This avoids mktemp, chmod on temp files from the beginning.
Contributor
Author
There was a problem hiding this comment.
Maybe something like this?
- source the
helper/scripts rather than embedding them- add the source command to each script in
bin/
- add the source command to each script in
- install the
helper/scripts in/usr/share/git-extras/helperor similar - separate out a
buildtarget from theinstalltarget - build each of the to-be-installed scripts in a pattern rule that would just add the install path for the
helper/scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.