other repl config ideas #1224
other repl config ideas #1224
Conversation
|
a few more ideas - maybe currently a bit messy, open to any feedback WDYT? |
| project_name="" | ||
| fi | ||
|
|
||
| prompt_base="$prefix$project_name$cur_string$es_string$prompt_character" |
There was a problem hiding this comment.
Need separator between $prefix and $project_name
bin/git-repl
Outdated
|
|
||
| show_project_name=$(git config --get --default 'false' git-extras.repl.show-project-name) | ||
| if [[ "$show_project_name" == "true" ]]; then | ||
| project_name=$(basename $(git config --get remote.origin.url) .git) |
There was a problem hiding this comment.
If the repo doesn't have a remote, this will cause an error. What about falling back to git rev-parse --show-toplevel?
There was a problem hiding this comment.
+1, noting that git config's --default doesn't quite fix this since git rev-parse --show-toplevel prints a directory that might end with .git.
There was a problem hiding this comment.
okay, i made it always be git rev-parse --show-toplevel, i can't think of a scenario where i would want git config --get remote.origin.url. if someone has two checkous, my-project and my-project-tmp, they would want to know they are in the -tmp variant.
There was a problem hiding this comment.
Just a small suggestion by me, otherwise looks great (aside from @spacewander's comments)
Co-authored-by: Edwin Kofler <[email protected]>
3 participants
Uh oh!
There was an error while loading. Please reload this page.