ability to specify command when hitting enter #1223
Conversation
jjb
force-pushed
the
default-empty-command-behavior
branch
from
cc5edfe to
1b79340
Compare
jjb
force-pushed
the
default-empty-command-behavior
branch
from
1b79340 to
7654970
Compare
| Any arguments to git repl will be taken as the first command to execute in | ||
| the repl. | ||
|
|
||
| You can specify a default command to run when hitting enter: |
There was a problem hiding this comment.
Let's also update https://github.com/tj/git-extras/blob/main/man/git-repl.md and generate new man page
| if test -n "$on_enter_cmd"; then | ||
| eval "$on_enter_cmd" | ||
| fi | ||
| continue |
There was a problem hiding this comment.
The continue will skip exit_status=$? below?
There was a problem hiding this comment.
before my change, when there was an empty command, the result was continue
after my change, now there is the optional command executed, and then always continue like before
(maybe you know this and are asking something else)
i just now tested the exit_status feature with and without git-extras.repl.on-enter-command being set and it still works
There was a problem hiding this comment.
@jjb
So the custom command, unlike the command input for prompt, doesn't affect the exit status. Is it intended?
hyperupcall
left a comment
hyperupcall
left a comment
There was a problem hiding this comment.
This LGTM assuming the comments by @spacewander are addressed!
3 participants
closes #1222