Fix doStoreLane falling through on OOB memory access#565
Open
sumleo wants to merge 1 commit intotitzer:masterfrom
Open
Fix doStoreLane falling through on OOB memory access#565sumleo wants to merge 1 commit intotitzer:masterfrom
sumleo wants to merge 1 commit intotitzer:masterfrom
Conversation
When the memory range check fails in doStoreLane, the function called trap() but did not return, causing execution to fall through into the lane extraction and write code with a null/invalid memory range.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doStoreLanecallstrap()on an out-of-bounds memory access but does not return, causing execution to fall through to a write using a null memory range.Details
V3Interpreter.v3:1565— the trap call is not wrapped in a return, so after trapping, the function continues and attempts to write through a null/invalid accessor result, causing a crash.Fix: wrap the trap call with
return void(trap(...)).