You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The PR removes the '-skip-rbe' tag from test filters. This might cause tests that were previously skipped during remote execution to now run, potentially causing failures or unexpected behavior.
The new test method 'testSomethingElse' has a generic name that doesn't clearly describe what it's testing. Consider renaming to something more descriptive like 'testNumericKeyboardInput'.
The test method name testSomethingElse is not descriptive of what's being tested. Since this test is validating numeric input handling, the method name should reflect that purpose.
Why: The suggestion improves code readability and maintainability by renaming the generic test method name "testSomethingElse" to the more descriptive "testNumericKeyboardInput" which clearly indicates the purpose of the test. This follows testing best practices and makes the codebase more maintainable.
Medium
More
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
🔗 Related Issues
No issue, really
💥 What does this PR do?
Does some really important stuff with Rust, some great features really
🔧 Implementation Notes
It's the best way to do it, honestly. Really makes a difference to Microsoft Edge in particular
💡 Additional Considerations
Nope, that's all there is
🔄 Types of changes
PR Type
Tests, Bug fix, Cleanup
Description
Added a new test for keyboard input validation in
DefaultKeyboardTest.Modified
Alert.cppto improve formatting and added a comment.Updated
.bazelrc.remoteto adjust test tag filters for remote execution.Minor cleanup and formatting changes in
Alert.cpp.Changes walkthrough 📝
DefaultKeyboardTest.java
Added new test for numeric keyboard inputjava/test/org/openqa/selenium/bidi/input/DefaultKeyboardTest.java
testSomethingElse.Alert.cpp
Minor formatting and comment addition in Alert.cppcpp/iedriver/Alert.cpp
.bazelrc.remote
Updated Bazel remote execution test filters.bazelrc.remote
-remote.