-
-
Notifications
You must be signed in to change notification settings - Fork 2
♻️ refactor: fix and update make file #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ refactor: fix and update make file #92
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughThe Makefile removes build metadata and the default target, restructures existing targets, and adds many new ones for release workflows, Git hooks, Docker, security checks, markdown linting, testing, install/uninstall, cleaning, and version reporting. Release and revert flows are updated, including OS-aware edits to a Go constants file. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant MK as Makefile
participant GH as Git Hooks
participant RS as Release Script
participant GT as Git
Dev->>MK: make release
activate MK
MK->>GH: check/install hooks
GH-->>MK: hooks ready
MK->>GT: check-release (branch, status, tags, commits)
GT-->>MK: status details
alt pre-checks pass
MK->>RS: invoke external release script
RS-->>MK: release tag/version output
MK-->>Dev: release complete
else pre-checks fail
MK-->>Dev: abort with status details
end
deactivate MK
sequenceDiagram
autonumber
actor Dev as Developer
participant MK as Makefile
participant FS as File System
participant SE as sed (OS-aware)
participant GT as Git
Dev->>MK: make revert-release
activate MK
MK->>FS: locate pkg/constants/constants.go
MK->>SE: apply version revert substitution
SE-->>MK: file updated
MK->>GT: commit revert changes
GT-->>MK: commit hash
MK-->>Dev: revert complete
deactivate MK
sequenceDiagram
autonumber
actor Dev as Developer
participant MK as Makefile
participant L1 as markdownlint-cli2
participant NPX as npx
participant SEC as gosec
Dev->>MK: make markdown-lint
alt cli2 available
MK->>L1: run lint
else fallback
MK->>NPX: run markdownlint-cli2 via npx
end
Dev->>MK: make security-check
alt gosec installed
MK->>SEC: run analysis
else missing tool
MK-->>Dev: instruct to install gosec
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~30 minutes Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Commit Validation PassedAll commits follow the conventional commit format! 🎉 Thank you for following our commit standards. This helps with:
|
|
🚨 Emergency Labeling Applied This PR was automatically labeled as "❓ Needs Review" because no other labels could be applied. Please:
This ensures proper organization and searchability of PRs. |
1 similar comment
|
🚨 Emergency Labeling Applied This PR was automatically labeled as "❓ Needs Review" because no other labels could be applied. Please:
This ensures proper organization and searchability of PRs. |
🚀 Description
🔄 Type of Change
📝 Changes Made
🧪 Testing
Test Results
📖 Documentation
🔗 Related Issues
Fixes #
Closes #
Related to #
📸 Screenshots/Examples
✅ Checklist
🎯 Focus Areas for Review
🚨 Breaking Changes
📝 Additional Notes
Please ensure all checks pass before requesting review
Summary by CodeRabbit
New Features
Improvements
Tests
Chores