Add resources unit tests; remove old test hook#159
Open
222448082Ashen wants to merge 1 commit intothoth-tech:mainfrom
Open
Add resources unit tests; remove old test hook#159222448082Ashen wants to merge 1 commit intothoth-tech:mainfrom
222448082Ashen wants to merge 1 commit intothoth-tech:mainfrom
Conversation
Add a new Catch2 test file (unit_test_resources.cpp) that verifies resources path utilities: path_to_resources, path_to_resources(kind), set_resources_path, and path_to_resource. The tests include helpers for platform path separators and an RAII guard to restore the original resources path after each test. Remove the old run_resources_tests declaration and its registration in the main test runner (test_main.h / test_main.cpp) since the resources tests are now handled by the new unit test file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds dedicated Catch2 coverage for resources path utilities and removes the legacy manual Resources test registration from the old sktest runner.
Summary of changes:
Motivation and context:
Dependencies required for this change:
Fixes #
Type of change
How Has This Been Tested?
Current status:
Reproduction steps:
Testing Checklist
Checklist