Migrate timeout state to Angular component#454
Open
WaelAlahamdi wants to merge 1 commit intothoth-tech:10.0.xfrom
Open
Migrate timeout state to Angular component#454WaelAlahamdi wants to merge 1 commit intothoth-tech:10.0.xfrom
WaelAlahamdi wants to merge 1 commit intothoth-tech:10.0.xfrom
Conversation
Collaborator
|
I tested this locally with the Doubtfire development container. Both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request migrates the timeout state from the legacy AngularJS/CoffeeScript implementation to an Angular component and removes the old timeout state wiring. This keeps the existing timeout functionality aligned with the current Angular-based structure used in the project. The legacy AngularJS timeout implementation is no longer used, and the migrated Angular timeout component was verified through local testing.
The change includes:
TimeoutComponenttimeout.tpl.htmltotimeout.component.htmldoubtfire.states.tsTimeoutComponentindoubtfire-angular.module.tsdoubtfire-angularjs.module.tssrc/app/errors/states/states.coffeetimeout.coffeefileFixes # (issue)
Type of change
How Has This Been Tested?
Test steps:
http://localhost:4200/#/timeout?dest¶msTesting Checklist:
Checklist: