Skip to content

Migrate/root controller#452

Open
Thirus224849242 wants to merge 5 commits intothoth-tech:10.0.xfrom
Thirus224849242:migrate/root-controller
Open

Migrate/root controller#452
Thirus224849242 wants to merge 5 commits intothoth-tech:10.0.xfrom
Thirus224849242:migrate/root-controller

Conversation

@Thirus224849242
Copy link
Copy Markdown

Description

This PR migrates the root-controller from CoffeeScript and AngularJS to TypeScript and Angular as part of the ongoing Doubtfire migration effort.

The original AppCtrl controller was empty with only a GlobalStateService injection and no implementation. The new RootControllerComponent maintains this behaviour while following the Angular component pattern.

Changes made:

  • Created root-controller.component.ts as the Angular replacement for root-controller.coffee
  • Registered RootControllerComponent in doubtfire-angular.module.ts declarations
  • Downgraded RootControllerComponent in doubtfire-angularjs.module.ts using downgradeComponent to maintain hybrid app compatibility
  • Registered AppCtrl controller in doubtfire-angularjs.module.ts to maintain compatibility with ng-controller="AppCtrl" in index.html
  • Removed doubtfire.config.root-controller from config.coffee
  • Deleted old root-controller.coffee

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

The app was loaded and tested locally after each change to ensure nothing broke. The ng-controller="AppCtrl" in index.html continues to work correctly via the downgradeComponent bridge.

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request
image image

@Thirus224849242 Thirus224849242 marked this pull request as ready for review April 2, 2026 08:18
Copy link
Copy Markdown

@WaelAlahamdi WaelAlahamdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Thirus224849242 ,
Reviewed locally and tested successfully. The migration keeps the original AppCtrl behaviour, replaces the old CoffeeScript/AngularJS root controller with the new TypeScript/Angular component, and maintains hybrid app compatibility through the downgrade bridge. No issues from my side. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants