-
Notifications
You must be signed in to change notification settings - Fork 1
M01_S01 #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
M01_S01 #35
Conversation
added environment assets for grass and roads. added residential road centerline asset (the map feature) and a few templates of various combinations of roads without crossings. did not create assets for grass items theme, will do before PR gets merged; did not create assets for road markings theme, will do before PR gets merged; did not create assets for road items theme, will do before PR gets merged. once road themes are created I will create and modify existing templates to use the items from the themes.
…tting previously, added a few road markings and grass features In the previous commit I forgot to resize the size of templates so that each only took up as only as much space as they needed to. added a few items to the grass items theme, these still need to be turned into isometric and made to look better. added some road marking to the road markings theme, still have to add these to the templates.
…ings
- added the road markings I already had to the road templates
- added stop signs and road markings
- added stop signs and markings to road templates
- added yield signs and road markings
- added yield signs and markings to road templates
|
thank you for sharing the updates. I'm just checking in with you here to let you know that I haven't forgotten about you. Things haven't changed much on my end, there's still a significant bandwidth crunch here with the new job. I just asked a long-time friend of mine to wait another month before we catch up to celebrate. I did take a brief look at the PR as it appears within GitHub. I like many of the things that you've done with the road markings and the road signs. I appreciate that you're thinking about all of that stuff. You're going to ensure that the project library will, eventually, be very comprehensive. A word of caution: the more things you add, the more risk you take. Doing the minimum to satisfy the PR helps ease my workload during review AND you minimize your risk of significant rework at the end of a feedback cycle. I do hope that comes across in the supportive sense that I intend it to. That's all. I will return as soon as possible. I did see the Mappy Hour posting in the PWG--and you know I'd join if I can squeeze it in. This entire month has been an intense blur. Be well, |
|
do you think that we can get away with not doing the grass items theme in this PR as I am doubt that I can pull something together that looks ok for that with my current art skills. for the bare minimum I think that the only things I have left to do for the minimum required is add kerbs (just raised kerbs) and presets that go to the height of the kerb along with renaming some of the files so that the naming scheme you asked for is used. currently the only work outside of the minimum that I plan to do is adding traffic light assets and adding them to the templates (seperate templates for each of the current that use traffic lights) and maybe some map features for icons of the included traffic signs and the traffic lights when mapped on vertexes ( |
|
Yes, that’s fine. I have an approach for the grass that I’d like to try
once I get my evenings back.
…On Thu, Jul 24, 2025 at 9:03 PM Udarian ***@***.***> wrote:
*Udarthegreat* left a comment (thompsondt/osm-kerb-kit#35)
<#35 (comment)>
do you think that we can get away with not doing the grass items theme in
this PR as I am doubt that I can pull something together that looks ok for
that with my current art skills.
—
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAL6IEZBWQJ5DDO4BRJRGXT3KF65JAVCNFSM6AAAAACAYGIY7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTCMJVGQ2TINJWG4>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
In this PR the goal is to complete issue #10,
I am putting this in draft mode for now as I have only up to this point done part of the work but I feel what I have is enough for comments to be left allowing me to go in the correct direction with this more easily.
What I have done up to this point
Todo
As mentioned above I was not fully able to create all the assets so below I have listed what I have yet to do, most if not all of this has a skeleton folder structure currently in this PR. I have included the a todo's in roughly the order I currently plan on implementing them and plan to do roughly one commit per Todo item in the list.
Questions:
As a final note here, I am happy to deal with any folder changes that are made to the repo before this merges my self and commit the change back to this PR once done. Also I made a small change to the git-ignore to add
.afdesign~lock~files, which are auto generated by affinity when you have a affinity designer file open so that they are not accidentally committed up to the repo as they would have no use in here.