Skip to content

Conversation

@Udarthegreat
Copy link

@Udarthegreat Udarthegreat commented Jul 4, 2025

In this PR the goal is to complete issue #10,
I am putting this in draft mode for now as I have only up to this point done part of the work but I feel what I have is enough for comments to be left allowing me to go in the correct direction with this more easily.

What I have done up to this point

  • created templates for the following road setups
    • one lane road with no intersection
    • two lane road with no intersection
    • a T intersection, both roads are two lane
    • a cross intersection, two lane
    • a 90 degree turn in the road, two lane
    • each of the above with stop signs
    • ~
  • I created a object that represents the center line of a residential road (based on how iD renders them), essentially how the OSM way would look
  • I created separate road and grass environment assets based on the placeholder tiles I used from the shared document.
  • started work on the road marking theme.
  • started work on the road items theme
  • started on the grass items theme but failed to get much done and will need help on that front.

Todo

As mentioned above I was not fully able to create all the assets so below I have listed what I have yet to do, most if not all of this has a skeleton folder structure currently in this PR. I have included the a todo's in roughly the order I currently plan on implementing them and plan to do roughly one commit per Todo item in the list.

  • grass items theme, essentially different items that can be placed on top of grass environment tiles to add some variation such as tufts of grass of various sizes
  • road markings theme, various simple road markings that can be put on top of a road tile, or set of road tiles to show things like lane count, stopping position and other bits of information that makes it clearer what we are talking about in any particular template. I will only implement the ones that are needed for issue M01_S01: Scene with Sidewalk Absent #10 and not others as to keep it simpler and those can be added at a later time in future PR's.
    • create versions of the existing templates with the road markings.
    • stop line
    • yield line
    • dashed yellow and white lines
    • double yellow and white lines
    • non-dashed yellow and white lines
    • look into if we need any other road markings for this PR.(I think I am done with these for this PR but am currently unsure).
  • road items theme, various items that go along a road, such as a stop or yield sign so as to add some variation and show how to map certain features that often come along with roads, and in the future once the rest of M01: Bronze-Tier Onboarding #13 is implemented how these interact with pedestrian features.
    • stop sign
    • yield sign
    • traffic light
    • mail drop off box (USPS and maybe others)
    • mail box (for private residence)
    • look into any others that need to be added
  • kerb environment features (just raised and rolled, lowered and flush along with other variants would be done for future PR's once pedestrian features are added).
  • correct naming scheme for files.

Questions:

  • should we have speed, bumps, humps and tables
  • should we have road name signs
  • should we have road information signs like those before highway entrance/exit ramps
  • should we have speed limit and advisory speed limit signs
  • how do we deal with road markings being covered by the OSM geometry representations
  • I am pretty sure the yield sign I created is correct but it doesn't look right for some reason
  • should I include buildings like houses into any of the templates

As a final note here, I am happy to deal with any folder changes that are made to the repo before this merges my self and commit the change back to this PR once done. Also I made a small change to the git-ignore to add .afdesign~lock~ files, which are auto generated by affinity when you have a affinity designer file open so that they are not accidentally committed up to the repo as they would have no use in here.

added environment assets for grass and roads. added residential road centerline asset (the map feature) and a few templates of various combinations of roads without crossings. did not create assets for grass items theme, will do before PR gets merged; did not create assets for road markings theme, will do before PR gets merged; did not create assets for road items theme, will do before PR gets merged. once road themes are created I will create and modify existing templates to use the items from the themes.
…tting previously, added a few road markings and grass features

In the previous commit I forgot to resize the size of templates so that each only took up as only as much space as they needed to.
added a few items to the grass items theme, these still need to be turned into isometric and made to look better.
added some road marking to the road markings theme, still have to add these to the templates.
…ings

 - added the road markings I already had to the road templates
 - added stop signs and road markings
     - added stop signs and markings to road templates
 - added yield signs and road markings
     - added yield signs and markings to road templates
@thompsondt
Copy link
Owner

thank you for sharing the updates. I'm just checking in with you here to let you know that I haven't forgotten about you. Things haven't changed much on my end, there's still a significant bandwidth crunch here with the new job. I just asked a long-time friend of mine to wait another month before we catch up to celebrate.

I did take a brief look at the PR as it appears within GitHub. I like many of the things that you've done with the road markings and the road signs. I appreciate that you're thinking about all of that stuff. You're going to ensure that the project library will, eventually, be very comprehensive. A word of caution: the more things you add, the more risk you take. Doing the minimum to satisfy the PR helps ease my workload during review AND you minimize your risk of significant rework at the end of a feedback cycle. I do hope that comes across in the supportive sense that I intend it to.

That's all. I will return as soon as possible. I did see the Mappy Hour posting in the PWG--and you know I'd join if I can squeeze it in. This entire month has been an intense blur.

Be well,
David

@Udarthegreat
Copy link
Author

Udarthegreat commented Jul 25, 2025

do you think that we can get away with not doing the grass items theme in this PR as I am doubt that I can pull something together that looks ok for that with my current art skills.

for the bare minimum I think that the only things I have left to do for the minimum required is add kerbs (just raised kerbs) and presets that go to the height of the kerb along with renaming some of the files so that the naming scheme you asked for is used. currently the only work outside of the minimum that I plan to do is adding traffic light assets and adding them to the templates (seperate templates for each of the current that use traffic lights) and maybe some map features for icons of the included traffic signs and the traffic lights when mapped on vertexes (highway=stops, highway=traffic_signals etc). Obviously if you tell me that one of the questions I put above should be included I will.

@thompsondt
Copy link
Owner

thompsondt commented Jul 25, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants