Circle Wallets

[d4mr]

Context:

• added WalletCredentials table with the plan to normalise all credentials, instead of storing it adhoc
• there's a isDefault row on credentials, with a restriction for one default per type. The default exists so users don't need to pass credential ID with every create wallet call
• instead of storing non-credential wallet provider related configuration adhoc, we have a walletProviderConfigs JSONB field that will be typed via zod
  • this makes it easier to add more wallet provider configurations without DB migrations

eventual migration plan to normalised credentials:

• on the dashboard, prevent people from creating a new backend wallet without linking to a credential. if one doesn't exist, we have a flow that auto creates a default credential from your existing default credential (stored in config today)
• for folks using the API:
  • when they try to create a new backend wallet, we auto create a default credential using the ones in config.
  • we BLOCK any API changes to modify the older configuration. This way we ensure that the Default credential doesn't go out of sync with the ones in config, (which breaks user expectations)
  • instead we ask them to use the credentials api instead
  • existing wallets that don't use credentials keep working, we keep backwards compatibility

---

PR-Codex overview

This PR focuses on enhancing wallet credential management, particularly for Circle wallets, by introducing new schemas, routes, and database structures. It also includes error handling improvements and updates to the wallet creation process.

Detailed summary

• Modified migration.sql to alter the wallet_credentials table.
• Updated error messages in get-wallet.ts.
• Added CircleWalletConfiguration type in config.ts.
• Implemented new request body schema for wallet credentials in create.ts.
• Added routes for creating and retrieving wallet credentials.
• Introduced caching for wallet credentials in get-wallet-credential.ts.
• Enhanced wallet credential creation logic in create-wallet-credential.ts.
• Added support for Circle wallet types in various schemas and functions.
• Updated Prisma schema to include walletProviderConfigs and WalletCredentials model.
• Improved error handling in wallet-related operations.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

[zeet-co]

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://tw-unreal-demo-engine-vwn0-pb-cir-332fe3.engine-aws-usw2.zeet.app before merging 😉

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@circle-fin/developer-controlled-wallets@7.0.0	environment, filesystem, network	0	1.4 MB	ashuk-circle

🚮 Removed packages: npm/ox@0.4.2

View full report↗︎

[joaquim-verges]

i see what you mean by so many files touched when adding a wallet type xD