[SDK] fix: Separate properties and attributes in NFTInput#829
Merged
joaquim-verges merged 1 commit intothirdweb-dev:mainfrom Jan 18, 2025
Merged
[SDK] fix: Separate properties and attributes in NFTInput#829joaquim-verges merged 1 commit intothirdweb-dev:mainfrom
joaquim-verges merged 1 commit intothirdweb-dev:mainfrom
Conversation
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this PR will be closed in 3 days. |
Member
|
thank you @yukia3e ! |
joaquim-verges
approved these changes
Jan 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
How this PR will be tested
Output
(Example: Screenshot/GIF for UI changes, cURL output for API changes)
PR-Codex overview
This PR focuses on updating the handling of
propertiesandattributesin themint-to.tsfiles for botherc721anderc1155contracts. The changes ensure thatpropertiesandattributesare set toundefinedif they are not present in themetadata.Detailed summary
propertiesassignment frommetadata.properties || metadata.attributestometadata.properties ?? undefined.attributesassignment withmetadata.attributes ?? undefinedin botherc721anderc1155files.