Move to tsup for bundling. Upgrade TS. Remove default exports #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also upgrade TS which was quite old
- fix TS issues after upgrading. Marked some as ts-expect-error due to struggle for fixing them.
lakardion
commented
Jan 13, 2025
| @@ -1,23 +1,19 @@ | |||
| { | |||
| "name": "@thinknimble/tn-forms", | |||
| "version": "3.2.1", | |||
Contributor
Author
There was a problem hiding this comment.
after we merge, a new PR will be created by the GH action and will ask to upgrade this to 3.3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
We've started having some problems with RN projects on expo 52 that use this library. This was calling out about issues with the default export. I reckon it has something to do with the way expo is resolving the library and how we're bundling this one.
Here, (besides fixing the above issue) I'd like to get this library to the same bundle/deploy workflow that we have in our other maintained library tn-models. Bringing it up to a more modern bundling tool and improving the deployment process with changeets
Tests
I released a canary
@thinknimble/[email protected]and installed in an expo 52 RN project. There were no issues.Added the changeset for releasing a 3.3.0 once this gets merged