Skip to content

Add a nullptr check when OTA gets cancelled within progress callback #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mwesenjak wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a nullptr check when OTA gets cancelled within progress callback #260

mwesenjak wants to merge 1 commit into from

Conversation

@mwesenjak
Copy link

@mwesenjak mwesenjak commented Apr 4, 2025 •
edited
Loading

Closes #259

MathewHDYT
MathewHDYT approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@MathewHDYT MathewHDYT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me thanks for the fix. Will include it in my Pull Request

@MathewHDYT MathewHDYT mentioned this pull request Apr 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MathewHDYT MathewHDYT MathewHDYT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cancelling OTA Update in Progress Callback leads to nullptr access

2 participants

@mwesenjak @MathewHDYT