Tools: Topology2: Move in DMIC capture gain from host to dai pipeline#9154
Closed
singalsu wants to merge 2 commits intothesofproject:mainfrom
Closed
Tools: Topology2: Move in DMIC capture gain from host to dai pipeline#9154singalsu wants to merge 2 commits intothesofproject:mainfrom
singalsu wants to merge 2 commits intothesofproject:mainfrom
Conversation
This change prepares for adding it instead to DMIC DAI copier pipeline. There it will control mute/unmute for all possible module copier connected other capture PCMs. The pipeline object gain-capture is replaced with simpler host-gateway-capture. The definition of DMIC0_HOST_PIPELINE_SINK need to be changed from gain to host-copier. With this patch, the typical DMIC capture path looks like: dai-copier --> eqiir --> module-copier --> host-copier Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This change adds volume and switch "Dmic0" into dai-copier pipeline. It ensures that all capture from DMIC follows the mute key control even if some other processing and PCMs are added to module copier. The patch adds a new pipeline class dai-copier-eqiir-gain-module-copier-capture. It is similar as replaced dai-copier-eqiir-module-copier-capture but adds the gain component. The confusing DMIC0_DAI_GAIN (set to eqiir) is removed from all top level topologies (nocodec, rt5682, sdw, hda). After this a typical DMIC0 pipeline looks like: dai-copier --> eqiir --> gain --> module-copier --> host-copier Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
Collaborator
Author
|
This change is needed to keep DMIC mute keys & LEDs functional for all DMIC capture PCMs. E.g. if adding another pipeline and PCM for beamformer and DRC as in #9146 the the PCM is not impacted by the mute switch. Here is an example with sof-hda-generic-4ch (before, after): The mtl-nocodec topology already demonstrates the issue where Dmic0 switch in gain.13.1 does not impact other PCMs. |
singalsu
commented
May 22, 2024
| <include/components/dai-copier.conf> | ||
| <include/controls/bytes.conf> | ||
| <include/components/eqiir.conf> | ||
| <include/components/pipeline.conf> |
Collaborator
Author
There was a problem hiding this comment.
Include of gain.conf is missing, build it worked because it was included somewhere else.
ranj063
reviewed
May 22, 2024
| @@ -0,0 +1,204 @@ | |||
| # | |||
Collaborator
There was a problem hiding this comment.
@singalsu if this PR is not too urgent, can it wait till the new pipeline extension template goes upstream?
Collaborator
Author
|
Closing this, the PR is now part of #9176 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.