Open
Conversation
This commit addes the cmake file changes to generate topology file to support TI's codec chip tac5572 Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
This commit addes the cmake file changes to generate topology file to support TI's amplifier tas2883 Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
Collaborator
|
Can one of the admins verify this patch?
|
Member
|
test this please |
lgirdwood
approved these changes
Feb 23, 2026
Add cmake configuration to generate topology file for TI TAC5672 codec with IV sense feedback enabled (SDW_AMP_FEEDBACK=true). Signed-off-by: Niranjan H Y <niranjan.hy@ti.com>
niranjanhyti
force-pushed
the
for-tac5572
branch
from
7887d72 to
a2ab21f
Compare
Collaborator
|
Link to the kernel side PR thesofproject/linux#5675 |
bardliao
reviewed
Mar 2, 2026
| @@ -55,6 +55,14 @@ PREPROCESS_PLUGINS=nhlt,NHLT_BIN=nhlt-sof-mtl-rt712-l0-4ch.bin,\ | |||
| HDMI1_ID=5,HDMI2_ID=6,HDMI3_ID=7,DMIC0_ENHANCED_CAPTURE=true,\ | |||
| EFX_DMIC0_TDFB_PARAMS=line4_pass,EFX_DMIC0_DRC_PARAMS=dmic_default" | |||
|
|
|||
| "cavs-sdw\;sof-mtl-tac5572-2ch\;PLATFORM=mtl,NUM_SDW_AMP_LINKS=1,\ | |||
| SDW_AMP_FEEDBACK=false,SDW_SPK_STREAM=Playback-SmartAmp,SDW_AMP_FEEDBACK_STREAM=Capture-SmartAmp,\ | |||
Collaborator
There was a problem hiding this comment.
SDW_AMP_FEEDBACK_STREAM is not necessary while SDW_AMP_FEEDBACK=false.
Collaborator
There was a problem hiding this comment.
In fact, I can't find 'SDW_AMP_FEEDBACK_STREAM' in the existing code. Did you define it somewhere?
bardliao
reviewed
Mar 2, 2026
|
|
||
| "cavs-sdw\;sof-mtl-tac5672-2ch\;PLATFORM=mtl,\ | ||
| NUM_SDW_AMP_LINKS=1,SDW_AMP_FEEDBACK=true,SDW_SPK_STREAM=Playback-SmartAmp,\ | ||
| SDW_AMP_FEEDBACK_STREAM=Capture-SmartAmp,SDW_SPK_IN_STREAM=SDW0-Capture-SmartAmp,\ |
Collaborator
There was a problem hiding this comment.
Please set SDW_SPK_IN_STREAM=Capture-SmartAmp, otherwise, the topology can be used when the codec is on SDW link0. Also, please double check if SDW_AMP_FEEDBACK_STREAM is used. I can't find it in the current code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the initial commit to support family of devices tac5xx2 with SoundWire interface.
This PR includes the changes for .cmake files to create the tplg files.