Breakout Room 7: Update main.py #13
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,23 @@ | ||
| #Mad Libs Generator Project | ||
| //Loop back to this point once code finishes | ||
|
Collaborator
There was a problem hiding this comment. Should this be a comment with #s?
Collaborator
There was a problem hiding this comment. Is this where the loop returns? |
||
| loop = 1 | ||
| while (loop < 9): | ||
|
Collaborator
There was a problem hiding this comment. This won't run enough times. Maybe increase to 11?
Collaborator
There was a problem hiding this comment. You could probably remove the parentheses here since the expression is pretty simple and they not required in Python. |
||
| // All the questions that the program asks the user | ||
| noun = input("Choose a noun: ") | ||
| plural_noun = input("Choose a plural noun: ") | ||
| second_noun = input("Choose a noun: ") | ||
| place = input("Name a place: ") | ||
| adjective = input("Choose an adjective (Describing word): ") | ||
| third_noun = input("Choose a noun: ") | ||
|
Comment on lines
+6
to
+11
Collaborator
There was a problem hiding this comment. Consider using a dictionary or data structure to hold these. |
||
| // Displays the story based on the users input | ||
| print ("------------------------------------------") | ||
| print ("Be kind to your",noun,"- footed", plural_noun) | ||
| print ("For a duck may be somebody's", seond_noun,",") | ||
|
|
||
| print ("Be kind to your",plural_noun,"in",place) | ||
| print ("Where the weather is always",adjective,".") | ||
| print () | ||
| print ("You may think that is this the",third_noun,",") | ||
| print ("Well it is.") | ||
| print ("------------------------------------------") | ||
|
Comment on lines
+13
to
+21
Collaborator
There was a problem hiding this comment. Maybe try using f-strings for more efficient formatting? |
||
| // Loop back to "loop = 1" | ||
|
Collaborator
There was a problem hiding this comment. Make comments more descriptive of accurate loop behavior |
||
| loop = loop + 1 | ||
|
Collaborator
There was a problem hiding this comment. Consider using loop += 1 |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
: D