[WIP] Vectorized tess-point in Python#12
Open
christinahedges wants to merge 7 commits intotessgi:masterfrom
Open
[WIP] Vectorized tess-point in Python#12christinahedges wants to merge 7 commits intotessgi:masterfrom
tess-point in Python#12christinahedges wants to merge 7 commits intotessgi:masterfrom
Conversation
Collaborator
christopherburke
left a comment
There was a problem hiding this comment.
I am fine with merging the work in progress additions that are currently located in sub directories. Currently, setup.cfg and setup.py are deleted and I am unfamiliar with the pyproject.toml format as well as the purpose of the poetry.lock file.
Will your code work if keep setup.cfg and setup.py for now and remove poetry.lock and pyproject.toml files?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @christopherburke, this is a first PR to make
tess-pointa faster tool that's easier to use in Python. This is absolutely a work in progress (WIP) and there's lots missing from this PR right now! At the moment there is functionality to go from Pixels -> RA/Dec, and not the other way around. I need to implement that!This PR has big changes to the API, and so I incremented the major version number. I changed the package structure around to make it easier to maintain, and added the first test of a few.
I'll open this now, and we can talk here about how to move forward!
To Do
tess_stars2px_reverse_function_entryandtess_stars2px_function_entrywith deprecation warnings