Treat headers with colspans as multiple ths #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 17, 2019 13:06
This allows columns that span multiple rows to correctly sort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not sure if you are interested in this, but I forked your code to support a use case of mine. I have a header which spans multiple columns, and I want to sort by the first column of that span, and then have subsequent columns sort according to their headers.
This is quite a simple change, but perhaps not something you want. It's obviously up to you. It's a bit of a corner case.
I guess the diff blew up because I work under unix, and so the line endings all changed. Really, the patch is small.
Anyway, take it if you want it.
I like your library, by the way. Not as heavyweight as jQuery.