Skip to content

Conversation

@ronja-ui
Copy link
Contributor

@ronja-ui ronja-ui commented Sep 5, 2024

added PR template

@ronja-ui ronja-ui requested a review from kortemik September 5, 2024 11:43
@ronja-ui ronja-ui self-assigned this Sep 5, 2024
@ronja-ui ronja-ui added the review label Sep 9, 2024
Copy link
Member

@kortemik kortemik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rat plugin needs an exception

@ronja-ui
Copy link
Contributor Author

ronja-ui commented Oct 1, 2024

rat plugin needs an exception

Doesn't the following line exclude everything, including pull request directory, in .github directory?

<!-- ci -->
 <exclude>.github/**</exclude>

@ronja-ui ronja-ui removed the review label Dec 5, 2024
@ronja-ui ronja-ui added review and removed review labels Apr 7, 2025
…hub/pull_request_template.md

one directory up
Copy link
Contributor

@StrongestNumber9 StrongestNumber9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, rat plugin was already managed via wildcards

@StrongestNumber9 StrongestNumber9 merged commit 9200c41 into main Apr 7, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants