Skip to content

Conversation

@Tiihott
Copy link
Contributor

@Tiihott Tiihott commented Aug 4, 2025

Description

Updated jooq auto-generated code adding initial support for the new schema changes. The new schema includes new logtag table and also a new logtag_id column for the existing logfile table.
Further PR:s are needed for fully migrating the reads to use the new normalized logtag table instead of the old logtag column of logfile table which will eventually be dropped from the table.

No changes done to tests as the old logtag column of logfile table is still being used for reads and tests pass as expected.

Resolves #209

Checklists

Testing

General

  • I have checked that my test files and functions have meaningful names.
  • I have checked that each test tests only a single behavior.
  • I have done happy tests.
  • I have tested only my own code.
  • I have tested at least all public methods.

Assertions

  • I have checked that my tests use assertions and not runtime overhead.
  • I have checked that my tests end in assertions.
  • I have checked that there is no comparison statements in assertions.
  • I have checked that assertions are in tests and not in helper functions.
  • I have checked that assertions for iterables are outside of for loops and both sides of the iteration blocks.
  • I have checked that assertions are not tested inside consumers.

Testing Data

  • I have tested algorithms and anything else with the possibility of unbound growth.
  • I have checked that all testing data is local and fully replaceable or reproducible or both.
  • I have checked that all test files are standalone.
  • I have checked that all test-specific fake objects and classes are in the test directory.
  • I have checked that my tests do not contain anything related to customers, infrastructure or users.
  • I have checked that my tests do not contain non-generic information.
  • I have checked that my tests do not do external requests and are not privately or publicly routable.

Statements

  • I have checked that my tests do not use throws for exceptions.
  • I have checked that my tests do not use try-catch statements.
  • I have checked that my tests do not use if-else statements.

Java

  • I have checked that my tests for Java uses JUnit library.
  • I have checked that my tests for Java uses JUnit utilities for parameters.

Other

  • I have only tested public behavior and not private implementation details.
  • I have checked that my tests are not (partially) commented out.
  • I have checked that hand-crafted variables in assertions are used accordingly.
  • I have tested Object Equality.
  • I have checked that I do not have any manual tests or I have a valid reason for them and I have explained it in the PR description.

Code Quality

  • I have checked that my code follows metrics set in Procedure: Class Metrics.
  • I have checked that my code follows metrics set in Procedure: Method Metrics.
  • I have checked that my code follows metrics set in Procedure: Object Quality.
  • I have checked that my code does not have any NULL values.
  • I have checked my code does not contain FIXME or TODO comments.

@Tiihott Tiihott requested a review from elliVM August 4, 2025 10:24
@Tiihott Tiihott self-assigned this Aug 4, 2025
elliVM
elliVM previously approved these changes Aug 5, 2025
Copy link
Contributor

@elliVM elliVM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM all old tests work

elliVM
elliVM previously approved these changes Aug 6, 2025
@Tiihott
Copy link
Contributor Author

Tiihott commented Aug 13, 2025

Created a separate issue #211 and PR #212 for updating jooq code with new epoch columns and indexes before implementing logtag normalization schema changes.

@Tiihott Tiihott dismissed elliVM’s stale review August 18, 2025 11:18

The merge-base changed after approval.

@Tiihott
Copy link
Contributor Author

Tiihott commented Aug 18, 2025

Rebased to main

elliVM
elliVM previously approved these changes Aug 25, 2025
@Tiihott
Copy link
Contributor Author

Tiihott commented Oct 29, 2025

Rebased to main

@Tiihott
Copy link
Contributor Author

Tiihott commented Oct 31, 2025

Rebased to main and updated StreamDBClientTest with the new schema.

@Tiihott Tiihott requested a review from elliVM November 3, 2025 09:16
Copy link
Contributor

@elliVM elliVM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check comment

@Tiihott Tiihott requested a review from elliVM November 3, 2025 11:12
elliVM
elliVM previously approved these changes Nov 3, 2025
Copy link
Contributor

@elliVM elliVM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Tiihott Tiihott changed the title Updated jooq auto-generated code to match new schema changes Updated jooq auto-generated code with new normalized logtag table for journaldb Nov 19, 2025
@Tiihott Tiihott added the review Issues or pull requests waiting for a review label Nov 19, 2025
@Tiihott
Copy link
Contributor Author

Tiihott commented Dec 1, 2025

Rebased to main

@Tiihott
Copy link
Contributor Author

Tiihott commented Dec 4, 2025

Rebased to main

@Tiihott Tiihott requested a review from elliVM December 19, 2025 12:28
@kortemik kortemik merged commit 043eeb9 into teragrep:main Jan 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review Issues or pull requests waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update jooq autogenerated code to match new schema changes

3 participants