-
Notifications
You must be signed in to change notification settings - Fork 9
Updated jooq auto-generated code with new normalized logtag table for journaldb #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
elliVM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM all old tests work
The merge-base changed after approval.
|
Rebased to main |
|
Rebased to main |
|
Rebased to main and updated StreamDBClientTest with the new schema. |
elliVM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check comment
elliVM
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
|
Rebased to main |
…olumn to logfile table. REBASE
…_id constraint naming.
|
Rebased to main |
Description
Updated jooq auto-generated code adding initial support for the new schema changes. The new schema includes new logtag table and also a new logtag_id column for the existing logfile table.
Further PR:s are needed for fully migrating the reads to use the new normalized logtag table instead of the old logtag column of logfile table which will eventually be dropped from the table.
No changes done to tests as the old logtag column of logfile table is still being used for reads and tests pass as expected.
Resolves #209
Checklists
Testing
General
Assertions
Testing Data
Statements
Java
Other
Code Quality