fix: require strict session receipts on all paid success paths#371
Merged
fix: require strict session receipts on all paid success paths#371
Conversation
Contributor
✅ Changelog found on PR. |
Amp-Thread-ID: https://ampcode.com/threads/T-019d1be1-b286-76e0-abd3-edf91311b9c9 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d1be1-b286-76e0-abd3-edf91311b9c9 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d1c7e-83ae-746d-8f05-3ade522513c8 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d1c8d-b530-701a-a4b6-c10b04b4c361 Co-authored-by: Amp <amp@ampcode.com>
5479030 to
f14ea5f
Compare
Amp-Thread-ID: https://ampcode.com/threads/T-019d1c8d-b530-701a-a4b6-c10b04b4c361 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d1c8d-b530-701a-a4b6-c10b04b4c361 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d1c8d-b530-701a-a4b6-c10b04b4c361 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d1c8d-b530-701a-a4b6-c10b04b4c361 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d1c8d-b530-701a-a4b6-c10b04b4c361 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up fixes to #349
Summary
This PR enforces strict session
Payment-Receiptvalidation for every successful paid session path, including reused persisted sessions. It removes warning-only handling and makes missing/malformed receipts and invalidspentsemantics deterministic protocol errors.What Changed
Payment-Receipthandling on successful paid responses in open/session flow paths.payment-receiptevent, voucher HEAD/POST updates, and top-up responses).spentsemantics (spentpresent, parseable, and<= acceptedCumulative) across all strict receipt paths.receipt.rs.Diff Scope
.changelog/strict-session-receipt-enforcement.mdcrates/tempo-request/src/payment/session/flow.rscrates/tempo-request/src/payment/session/receipt.rscrates/tempo-request/src/payment/session/streaming.rscrates/tempo-request/tests/session/harness.rscrates/tempo-request/tests/session/spec_alignment.rscrates/tempo-request/tests/session/streaming.rsBehavior Change
Validation
make check