ci: harden workflows for fork PRs and add workflow validation#367
Merged
ci: harden workflows for fork PRs and add workflow validation#367
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019d1be1-b286-76e0-abd3-edf91311b9c9 Co-authored-by: Amp <amp@ampcode.com>
Contributor
|
Amp-Thread-ID: https://ampcode.com/threads/T-019d1be1-b286-76e0-abd3-edf91311b9c9 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d1be1-b286-76e0-abd3-edf91311b9c9 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d1be1-b286-76e0-abd3-edf91311b9c9 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d1be1-b286-76e0-abd3-edf91311b9c9 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d1be1-b286-76e0-abd3-edf91311b9c9 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d1be1-b286-76e0-abd3-edf91311b9c9 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkjob in.github/workflows/changelog.ymltempo-lintsfork-safe by disabling PR comment posting in CI validationchangelog-generatepull_request_targetflow with same-repo gating, branch-ref validation, and safer push behaviorpr-auditreusable workflow invocation on issue commentsworkflow-validationCI workflow withactionlintand policy checks for workflow security/fork-safety invariantsspec_alignmentby replacing fixed sleeps with observable readiness checks and safer channel setupWhy
PR #349 was failing required checks in fork context due to permission and auth assumptions in workflows (comment-write and tokenized git auth behavior). These changes make required checks deterministic and safe for both branch and fork PRs while tightening security posture.
Validation
make checkcargo test -p tempo-request --test session -- new_session_while_prior_stream_active_recovers_without_state_corruption