feat: add RedisStore for production multi-instance deployments#94
Open
0xzoz wants to merge 1 commit intotempoxyz:mainfrom
Open
feat: add RedisStore for production multi-instance deployments#940xzoz wants to merge 1 commit intotempoxyz:mainfrom
0xzoz wants to merge 1 commit intotempoxyz:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing MemoryStore works well for single-process deployments, but breaks in multi-instance environments — two server instances share no state, so a challenge issued by instance A can be replayed against instance B.
This PR adds RedisStore, a Redis-backed implementation of the Store protocol that solves this with atomic SET NX EX operations (no race conditions, no separate TTL call).
Usage:
Includes: RedisStore + init.py, 7 tests, pympp[redis] optional dep.
Install with: pip install pympp[redis]