feat: replace static icons with logo.dev + Vercel Blob sync#417
Open
brendanjryan wants to merge 2 commits intomainfrom
Open
feat: replace static icons with logo.dev + Vercel Blob sync#417brendanjryan wants to merge 2 commits intomainfrom
brendanjryan wants to merge 2 commits intomainfrom
Conversation
- Add scripts/sync-logos.ts to fetch logos from logo.dev and upload to Vercel Blob - Add GitHub Actions workflow to run sync on deploy (when discovery.json changes) - Add /api/icon-manifest endpoint for transparency/lightBg metadata - Simplify /api/icon to read-only from blob (404 on miss) - Use manifest-based invert instead of CSS var for dark mode icons - Delete public/icons/ static SVGs and scripts/gen-icons.cjs - Remove gen-icons.cjs CI freshness check
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplified alternative to #410.
What changed
scripts/sync-logos.ts— single script fetches logos from logo.dev, detects transparency/light backgrounds via PNG pixel decoding, uploads to Vercel Blob, writes_manifest.json.github/workflows/sync-logos.yml— runs sync on push to main whendiscovery.jsonchanges (+ manual trigger). No cron./api/icon— simplified to read-only from Vercel Blob, 404 on miss/api/icon-manifest— new endpoint serving transparency/lightBg metadata--icon-invertvarpublic/icons/*.svg(67 files),scripts/gen-icons.cjs, CI icon freshness checkDropped from #410
VTCDuBoisTrial→VTCDuBois)brand.mdxservice logos sectionSetup
Add these secrets to the repo:
BLOB_READ_WRITE_TOKEN(already exists)LOGODEV_PUBLIC_KEYThen trigger the sync workflow manually for initial seed, or push a discovery.json change.